fix: close a superseding or superseded sibling PR before regenerating - #7
Merged
Merged
Conversation
discover-stranded-prs' regenerate_pr path had no equivalent of bump-and-open-pr's own close-then-create step, so a stranded PR regenerated from an older release could coexist indefinitely alongside a separately-dispatched, correctly-created PR for a newer release of the same package -- neither path ever closed the other. Confirmed directly against novus-power/hive: PR #1926 (documents.js@7.14.0, regenerated via this path) and PR #1927 (documents.js@7.15.0, opened directly by bump-and-open-pr) survived side by side. Checks for any other open sibling-update/<package>-* PR before doing anything else: if it's at or above this branch's own version, this regeneration is itself already superseded, so the stranded PR is closed outright and nothing is regenerated; if it's strictly older, it's closed the same way bump-and-open-pr's own close-then-create step would, since that step never got a chance to see this regeneration coming.
Codex Review SummaryThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
|
🎉 This PR is included in version 1.0.4 🎉 The release is available on GitHub release Your semantic-release bot 📦🚀 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
discover-stranded-prs' regenerate_pr path had no equivalent of bump-and-open-pr's own close-then-create step, so a stranded PR regenerated from an older release could coexist indefinitely alongside a separately-dispatched, correctly-created PR for a newer release of the same package -- neither path ever closed the other.
Confirmed directly against novus-power/hive: PR #1926 (documents.js@7.14.0, regenerated via this path) and PR #1927 (documents.js@7.15.0, opened directly by bump-and-open-pr) survived side by side.
Checks for any other open sibling-update/-* PR before doing anything else: if it's at or above this branch's own version, this regeneration is itself already superseded, so the stranded PR is closed outright and nothing is regenerated; if it's strictly older, it's closed the same way bump-and-open-pr's own close-then-create step would, since that step never got a chance to see this regeneration coming.
Test plan